Skip to content

feat: DAH-3315 send listingType and leasingAgent for email #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

cade-exygy
Copy link
Collaborator

@cade-exygy cade-exygy commented Apr 30, 2025

Description

Client integration piece for https://github.com/SFDigitalServices/sf-dahlia-backend/pull/18

  • Passes listingType and leasingAgent info to messaging service after application confirmation

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3315

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

Review Instructions

Will change instructions once I get review environments configured

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2630 April 30, 2025 18:56 Inactive
@cade-exygy cade-exygy temporarily deployed to dahlia-webapp-pr-2630 April 30, 2025 21:33 Inactive
@alulabeshue-sfgov alulabeshue-sfgov temporarily deployed to dahlia-webapp-pr-2630 May 2, 2025 21:30 Inactive
@alulabeshue-sfgov alulabeshue-sfgov temporarily deployed to dahlia-webapp-pr-2630 May 2, 2025 22:32 Inactive
Copy link
Contributor

@alulabeshue-sfgov alulabeshue-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After submitting an application office hours are missing from the email. I believe it is because the field name is called incorrectly.

name: listing.Leasing_Agent_Name.to_s,
email: listing.Leasing_Agent_Email.to_s,
phone: listing.Leasing_Agent_Phone.to_s,
officeHours: listing.Leasing_Agent_Office_Hours.to_s,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: I believe this should be listing.Office_Hours, like in this code example

@cade-exygy cade-exygy temporarily deployed to dahlia-webapp-pr-2630 May 5, 2025 19:47 Inactive
Copy link
Contributor

@alulabeshue-sfgov alulabeshue-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cade-exygy cade-exygy temporarily deployed to dahlia-webapp-pr-2630 May 12, 2025 19:40 Inactive
@cade-exygy cade-exygy merged commit e98989f into main May 12, 2025
19 of 20 checks passed
@cade-exygy cade-exygy deleted the DAH-3315-leasing-agent-info-messaging branch May 12, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants