Skip to content

Show Uncertainty Glyphs #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Aug 24, 2022
Merged

Show Uncertainty Glyphs #2369

merged 30 commits into from
Aug 24, 2022

Conversation

tarkpate
Copy link
Contributor

@tarkpate tarkpate commented Jan 28, 2022

-Added module to visualize tensor field uncertainty using glyphs
-Added uncertainty glyph builder class to tensor glyph builder file
-Added test network
-Moved some files from Core::Algorithm that should be in Graphics::Datatypes

Note: The glyph surface is not mathematically correct, so I put an experimental label in the module

@dcwhite dcwhite requested review from dcwhite and jessdtate February 4, 2022 17:55
@dcwhite dcwhite self-assigned this Feb 4, 2022
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Feb 4, 2022
@dcwhite
Copy link
Member

dcwhite commented Mar 18, 2022

/Users/runner/work/SCIRun/SCIRun/src/Interface/Modules/Visualization/ShowUncertaintyGlyphsDialog.cc:37:77: error: unused parameter 'name' [-Werror,-Wunused-parameter]
ShowUncertaintyGlyphsDialog::ShowUncertaintyGlyphsDialog(const std::string& name,

@tarkpate
Copy link
Contributor Author

tarkpate commented May 9, 2022

I'm going to add comments to explain the uncertainty glyph's variable naming soon. I wanted to get the builds going first.

Copy link
Contributor

@jessdtate jessdtate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the major "un-named" variables are qn and P. qn seems to be a discretization of q or Q from the paper. Does that match what see @RubioJr9? if so, maybe it would be better as q_i to be more consistent with the paper? p is a point/angle on the glyph, right? I think it's fine to leave it as p in that case.

I didn't see others that weren't part of loops.

@tarkpate
Copy link
Contributor Author

It seems that the major "un-named" variables are qn and P. qn seems to be a discretization of q or Q from the paper. Does that match what see @RubioJr9? if so, maybe it would be better as q_i to be more consistent with the paper? p is a point/angle on the glyph, right? I think it's fine to leave it as p in that case.

I didn't see others that weren't part of loops.

I don't think it is a discretization. I think the qn variable is a measure of finite differences in each of the 6 degrees of freedom of the mean tensor.

@dcwhite
Copy link
Member

dcwhite commented Jul 27, 2022

@jessdtate Just waiting on your approval on this one too

@dcwhite dcwhite merged commit f822eaa into SCIInstitute:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants