Skip to content

Composite module part 1 of many #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Nov 16, 2021
Merged

Composite module part 1 of many #2333

merged 48 commits into from
Nov 16, 2021

Conversation

dcwhite
Copy link
Member

@dcwhite dcwhite commented Nov 9, 2021

Mostly infrastructure to support network execution within a module's execute function.

Includes initial version of wildcard-port generalized composite module, to be iterated on before the lunch.

Also has the fix for combo boxes found by @jessdtate

dcwhite added 30 commits September 9, 2021 14:41
@dcwhite
Add module skeleton
a4c1df1
@dcwhite
Refactoring
411f569
@dcwhite
Major renaming WIP
a6d59de
@dcwhite
Builds
d73a978
@dcwhite
Update ControllerInterfaces.h
84f61b6
@dcwhite
Interface for xml classes WIP
e199e32
@dcwhite
Red
06153dc
@dcwhite
Green
40a0db5
@dcwhite
Refactor
429c7f9 
Move methods to NEC
@dcwhite
Store network pointer on each module
d4b6a11
@dcwhite
Add subnet clone method
b324bee
@dcwhite
Subnet modules created manually!
6e04340
@dcwhite
Internal connection made
af07edf
@dcwhite
Working on subnet execute
99d640d
@dcwhite
Composite is executing subnet
518e2ca
@dcwhite
Basic plumbing works
206e1bb
@dcwhite
Execution infra
149106a
@dcwhite
Working on enabling concurrent execution
00734b0
@dcwhite
Merge branch 'master' into composite-module
92f97da
@dcwhite
Fix for unique_ptr
071891a
@dcwhite
Split up large file for debug build
a65c901
@dcwhite
Debugging stuff
d6ee1af
@dcwhite
Reformat
ca26a5c
@dcwhite
Joining that thread doesnt work
b340ead
@dcwhite
Create compositeModuleHardcoded_Test.srn5
4600a13
@dcwhite
Refactor toward future value
9660041
@dcwhite
Fix pointer
ea3b8de
@dcwhite
Refactoring WIP
507e99e
@dcwhite
Introduce simple execution manager
cd261c0
@dcwhite
Waiting for future value works!!!
dff8f62
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Nov 9, 2021
@dcwhite dcwhite requested review from jessdtate and GPayne November 9, 2021 21:00
@dcwhite dcwhite self-assigned this Nov 9, 2021
GPayne
GPayne previously approved these changes Nov 10, 2021
View reviewed changes
@dcwhite dcwhite requested a review from GPayne November 15, 2021 15:30
jessdtate
jessdtate approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@jessdtate jessdtate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The universal ports require the user to correctly connect the types, otherwise there is a crash, but that seems to be a general problem.

@dcwhite dcwhite mentioned this pull request Nov 16, 2021
Closed
@dcwhite dcwhite merged commit 3684fe5 into master Nov 16, 2021
@dcwhite dcwhite deleted the composite-module branch November 16, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessdtate jessdtate jessdtate approved these changes

@GPayne GPayne Awaiting requested review from GPayne

Assignees

@dcwhite dcwhite

Labels
Framework Modules Network
Projects
None yet
Milestone
5.0-beta.ZZZ [Conference]
Development

Successfully merging this pull request may close these issues.
3 participants
@dcwhite @jessdtate @GPayne