-
Notifications
You must be signed in to change notification settings - Fork 73
Matlab strings--potential fix for scipy read error #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There seems to be a problem reading integer matrices into scirun now. Before, they could be read from matlab. Here is the error from a saved matrix (same from Python and matlab): Message: Import failed. Matlab_save_int_matrix.mat.zip |
There is a bit of inconsistency with ints in matrices, which may be the source of the issue. it seems the modules that work (like getfielddata) just convert it to a double. This doesn't seem to be happening correctly in read field. |
OK I'll take a look |
a slight correction, ints from matlab didn't work either, but the error was just: import failed. |
I can get it to work with any fields. I still get the error: TypeError: Expecting miINT8 as data type |
OK I'll close this and come up with a different fix. |
Maybe we should merge this into master? It works with matrix files, so it's half fix at least. I've been including it in local builds for a while to deal with matrix files. |
I can see if I can merge it in with a feature flag--enabled at run-time, or a setting which you can save as turned on. |
@jessdtate can you verify this fixes the scipy error referenced in #1692? Also check round-trip save/load for basically every other matlab file type and program that reads/writes such types...