Skip to content

Added example for new global parameters apply-namespace-modules/resou… #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

MNoeva
Copy link

@MNoeva MNoeva commented Jul 3, 2024

Description:

Added new parameters for namespaces;

cloudfoundry/multiapps#265
cloudfoundry/multiapps-controller#1492
cloudfoundry/multiapps-cli-plugin#204

Issue: LMCROSSITXSADEPLOY-2881

Copy link

cla-assistant bot commented Jul 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Noeva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Jul 3, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Noeva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ikasarov ikasarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're adding an example make sure to also add a description of the deployment and what it acheives here
https://github.com/SAP-samples/cf-mta-examples/blob/main/namespace/README.adoc
also you might add a little tooltip for the specific plugin version that accepcts the new parameters as well and only merge into examples repo after the releases

@MNoeva MNoeva force-pushed the namespace branch 2 times, most recently from c5a7c5b to be8fead Compare September 19, 2024 15:03
@ikasarov ikasarov merged commit f603a56 into SAP-samples:main Sep 20, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants