Skip to content

Add Github Action for Publishing to Comfy Registry #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 22, 2024

This PR adds a Github Action (publish-node-action) that will run whenever the pyproject.toml file changes. The pyproject.toml defines the custom node version you want to publish (added in another PR).

Action Required:

  • Make sure the trigger branch (master or main) in publish.yaml matches the branch you want to use as the publishing branch. It will only trigger when the pyproject.toml gets updated on that branch.
  • Create an api key on the Registry for publishing from Github. Instructions.
  • Add it to your Github Repository Secrets as REGISTRY_ACCESS_TOKEN.

More info on the registry.
Please message me on Discord if you have any questions!

@Ryuukeisyou Ryuukeisyou merged commit 14e4926 into Ryuukeisyou:main Jun 28, 2024
@Ryuukeisyou
Copy link
Owner

@haohaocreates hi and thank you for the pr. i have followed the instruction and published the nodes. and yet i still see in the comfyui manager that the nodes were updated on 5.22, instead of 6.28? is there anything i am missing? thank you!

@haohaocreates
Copy link
Contributor Author

haohaocreates commented Jun 28, 2024 via email

@Ryuukeisyou
Copy link
Owner

hey!!! can you link me your node and I can take a look? 😊

On Fri, Jun 28, 2024 at 4:20 AM Ryuukeisyou @.> wrote: @haohaocreates https://github.com/haohaocreates hi and thank you for the pr. i have followed the instruction and published the nodes. and yet i still see in the comfyui manager that the nodes were updated on 5.22, instead of 6.28? is there anything i am missing? thank you! — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BG3AD2IV3XAIEFZHJPXVXV3ZJUMDLAVCNFSM6AAAAABIEPVSHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGM4DQMZXHA . You are receiving this because you were mentioned.Message ID: @.>

hi, i am not sure if this is the link?:
https://registry.comfy.org/publishers/ryuukeisyou/nodes/comfyui_face_parsing

@haohaocreates
Copy link
Contributor Author

hey!!! can you link me your node and I can take a look? 😊

On Fri, Jun 28, 2024 at 4:20 AM Ryuukeisyou @.> wrote: @haohaocreates https://github.com/haohaocreates hi and thank you for the pr. i have followed the instruction and published the nodes. and yet i still see in the comfyui manager that the nodes were updated on 5.22, instead of 6.28? is there anything i am missing? thank you! — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BG3AD2IV3XAIEFZHJPXVXV3ZJUMDLAVCNFSM6AAAAABIEPVSHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGM4DQMZXHA . You are receiving this because you were mentioned.Message ID: _@**.**_>

hi, i am not sure if this is the link?: https://registry.comfy.org/publishers/ryuukeisyou/nodes/comfyui_face_parsing

right!!!! okay so the registry is still in the middle of being integrated with the UI-manager! we'll be making a public announcement once it is - that's why there might be a discrepancy between the two right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants