Use WebsocketClient protocol to support mocking

[fb55]

fixes #22

[freak4pc]

CI is failing @fb55

[fb55]

Turns out there is actually a missing property in this protocol. I've opened daltoniam/Starscream#564 to fix this.

[freak4pc]

Nice catch @fb55 ! Thanks for taking care of this 🎉 !

[fassko]

@fb55 Your PR daltoniam/Starscream/pull/564 is merged and I released Starscream 3.0.6

[fb55]

I'm having issues updating the dependencies to make tests pass for this PR. Would appreciate if someone could tackle #21, so this can piggy-back on it.

[freak4pc]

I'm on it @fb55 ;-)

[fb55]

Amazing, thanks :)

[freak4pc]

@fb55 I rebased your branch on top of master but build is still failing. I'm not sure you'll be able to use the protocol this way unless it would be protocol WebSocketClient: class. I think it'll actually need to be a concrete class if you're using a DelegateProxy 🤔

[fb55]

@freak4pc Should be good to go now. tl;dr Protocol types do not conform to themselves, the way around this is to use a generic that conforms to the protocol.

A bit of background: I went to Stack Overflow for this, where this response helped figure things out.

[fb55]

@freak4pc Would appreciate a review for this!

[freak4pc]

Hey @fb55 ! Looks goo, thank you for this! 🙏

[rxswiftcommunity]

Thanks a lot for contributing @fb55! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

[fb55]

@freak4pc I created a release for this — hope that's okay!

[fb55]

There seems to be an error that prevents the publish script from working: https://circleci.com/gh/RxSwiftCommunity/RxStarscream/56

[freak4pc]

Hey Felix. Sorry, didn't have the time to look into this, I'll try to take a poke at this today. Thanks for letting me know !

[freak4pc]

Pushed 0.10 manually. Thanks !