Skip to content

Use spirv2 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025
Merged

Use spirv2 #39

merged 5 commits into from
Apr 15, 2025

Conversation

Firestar99
Copy link
Member

Can't get rid of rem_euclid yet due to mismatched function signature in num-traits: rust-num/num-traits#349

@Firestar99 Firestar99 marked this pull request as ready for review April 13, 2025 09:38
@Firestar99 Firestar99 requested a review from LegNeato April 13, 2025 09:38
@Firestar99 Firestar99 marked this pull request as draft April 13, 2025 09:39
@Firestar99
Copy link
Member Author

I wish we had CI to verify I didn't break any shadertoys, but visually didn't notice anything (apart from skyline being broken, but that's been since you've updated it)

@LegNeato LegNeato marked this pull request as ready for review April 13, 2025 13:36
@LegNeato LegNeato marked this pull request as draft April 13, 2025 13:37
@LegNeato
Copy link
Contributor

I mean we could. They are deterministic and we could install lavapipe like my rust-gpu difftest diff does (cribbed from bevy)

@Firestar99 Firestar99 marked this pull request as ready for review April 14, 2025 09:30
@Firestar99
Copy link
Member Author

@LegNeato rebased and inlined some more things

@Firestar99 Firestar99 merged commit 56774fd into main Apr 15, 2025
@LegNeato LegNeato deleted the use_spirv2 branch April 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants