Updated library to use new API #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCelavi
requested changes
Feb 14, 2024
|
|
||
| private function getApiRateTypes(): array | ||
| { | ||
| return [ |
There was a problem hiding this comment.
On every call of this function - you are building a new array, allocating more memory. We know that there are going to be dozens of these calls.
Make it private constant of this class.
| return Api::NAME; | ||
| } | ||
|
|
||
| private function buildRate($value, $currencyCode, $rateType, $date): RateInterface |
There was a problem hiding this comment.
Do you need this private function? It is used once, and it is one liner.
Seams that you can just move construction to place where is needed, without using function, makes no sense to have it.
stefan1144
force-pushed
the
feature/switch-to-new-api
branch
from
abf4c40 to
6424041
Compare
TheCelavi
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.