Skip to content

regression: wrong unread count on favicon #36150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jun 4, 2025

ARCH-1633

Proposed changes (including videos or screenshots)

favicon unread badge was being duplicated:
image
fix:

  • move manageFavicon out of useUnread hook

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Jun 4, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36150/

Built to branch gh-pages at 2025-06-05 19:34 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (e9904fe) to head (bcdb090).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36150   +/-   ##
========================================
  Coverage    64.56%   64.57%           
========================================
  Files         3123     3123           
  Lines        97850    97850           
  Branches     18528    18527    -1     
========================================
+ Hits         63178    63184    +6     
+ Misses       31851    31843    -8     
- Partials      2821     2823    +2     
Flag Coverage Δ
e2e 57.59% <100.00%> (+0.02%) ⬆️
unit 69.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti added this to the 7.8.0 milestone Jun 4, 2025
@juliajforesti juliajforesti marked this pull request as ready for review June 4, 2025 18:55
@juliajforesti juliajforesti requested a review from a team as a code owner June 4, 2025 18:55
@juliajforesti juliajforesti changed the title fix: wrong unread count on favicon regression: wrong unread count on favicon Jun 4, 2025
Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: bcdb090

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 4, 2025
@kodiakhq kodiakhq bot merged commit d6df5f4 into develop Jun 5, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/unread-favicon branch June 5, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants