Skip to content

regression: Twilio failing signature check #36103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented May 28, 2025

Backport of #36077

@dionisio-bot dionisio-bot bot requested review from a team as code owners May 28, 2025 16:41
@dionisio-bot dionisio-bot bot requested a review from KevLehman May 28, 2025 16:41
Copy link

changeset-bot bot commented May 28, 2025

⚠️ No Changeset found

Latest commit: 7f5bbdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented May 28, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label May 28, 2025
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36103/

Built to branch gh-pages at 2025-05-28 17:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.23%. Comparing base (5713aed) to head (7f5bbdf).
Report is 2 commits behind head on release-7.6.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.2   #36103      +/-   ##
=================================================
+ Coverage          59.75%   61.23%   +1.48%     
=================================================
  Files               2855     3156     +301     
  Lines              69756    74676    +4920     
  Branches           15439    16684    +1245     
=================================================
+ Hits               41681    45727    +4046     
- Misses             25393    25849     +456     
- Partials            2682     3100     +418     
Flag Coverage Δ
e2e 58.09% <ø> (+3.75%) ⬆️
unit 74.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label May 30, 2025
@kodiakhq kodiakhq bot merged commit 0b5939b into release-7.6.2 May 30, 2025
52 of 53 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.6.2-36077 branch May 30, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants