Skip to content

fix: remove apps-engine dependency on internal package #36033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented May 20, 2025

Backport of #36007

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner May 20, 2025 13:38
@dionisio-bot dionisio-bot bot requested a review from d-gubert May 20, 2025 13:38
Copy link

changeset-bot bot commented May 20, 2025

🦋 Changeset detected

Latest commit: 8076d7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented May 20, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36033/

Built to branch gh-pages at 2025-05-20 13:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.24%. Comparing base (8683f0d) to head (8076d7c).
Report is 1 commits behind head on release-7.6.1.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.1   #36033      +/-   ##
=================================================
+ Coverage          59.75%   61.24%   +1.48%     
=================================================
  Files               2855     3156     +301     
  Lines              69756    74674    +4918     
  Branches           15439    16684    +1245     
=================================================
+ Hits               41681    45731    +4050     
- Misses             25393    25842     +449     
- Partials            2682     3101     +419     
Flag Coverage Δ
e2e 58.11% <ø> (+3.76%) ⬆️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label May 21, 2025
@d-gubert d-gubert added this to the 7.6.0 milestone May 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 21, 2025
@kodiakhq kodiakhq bot merged commit 587c3ca into release-7.6.1 May 21, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.6.1-36007 branch May 21, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant