fix: upload of malformed jpegs with Message_Attachments_Strip_Exif disabled fails silently #35839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bff8ede The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kodus-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35839 +/- ##
===========================================
+ Coverage 64.62% 64.77% +0.15%
===========================================
Files 3244 3093 -151
Lines 95388 92144 -3244
Branches 17851 17517 -334
===========================================
- Hits 61643 59689 -1954
+ Misses 30849 29703 -1146
+ Partials 2896 2752 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
May be worth looking into sharp 0.34: lovell/sharp#3947 (comment) |
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…nto SUP-769-Image-Upload-Display-Error-Message-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…nto SUP-769-Image-Upload-Display-Error-Message-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
cardoso
changed the title
|
@kody start-review |
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
MarcosSpessatto
previously requested changes
Apr 24, 2025
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
MarcosSpessatto
previously approved these changes
Apr 30, 2025
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
dougfabris
requested changes
May 7, 2025
apps/meteor/client/views/room/body/UploadProgress/UploadProgressIndicator.tsx
Outdated
Show resolved
Hide resolved
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: Douglas Fabris <[email protected]>
MarcosSpessatto
previously approved these changes
May 8, 2025
dougfabris
requested changes
May 8, 2025
Changes the selector for identifying image upload errors. This avoids relying on specific text content and improves the robustness of the test.
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
…e-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
kodiakhq
bot
deleted the
SUP-769-Image-Upload-Display-Error-Message-on-Failure-Silent-Fail-for-Specific-JPEGs-ufs-VipsJpeg-errors
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
SUP-769
Steps to test or reproduce
Further comments
Description
This pull request addresses an issue in the Rocket.Chat repository where image uploads were failing for specific JPEG files. The problem only occurs when Message_Attachments_Strip_Exif is set to false (current default is true). Some of the upload logic which uses xhr also needed tweaking, and the frontend side needed to display the error.