-
Notifications
You must be signed in to change notification settings - Fork 1.3k
IrisNp2 Option to Add Hyperplanes Even After Passing the Probabilistic Test #23102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f8a2dd3
to
b37852c
Compare
+@wernerpe for feature review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your use case for this option? why not just make the unadaptive test more stringent?
Reviewable status: LGTM missing from assignee wernerpe, needs platform reviewer assigned, needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change originally resulted from a stackoverflow poster having issues with IrisZo producing regions that had too many collisions -- sample GCS paths were not collision-free. Setting the fraction in collision and probability of failure to 1e-2 and 1e-3 both fail -- 1e-4 is required. But this is very slow, with some regions taking up to 100 seconds to produce. On the other hand, using 1e-2 together with this new option, kept region generation times around half a second and led to collision-free paths. So this seems like a pretty solid quality-of-life change.
Reviewable status: LGTM missing from assignee wernerpe, needs platform reviewer assigned, needs at least two assigned reviewers
@drake-jenkins-bot retest this please |
b37852c
to
fb05009
Compare
…n the last inner iteration, even if that iteration already passed the collision-free probabilistic test.
fb05009
to
a2707ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
Closes #23050. Holding off on review until #23096 lands.
This change is