Skip to content

IrisNp2 Option to Add Hyperplanes Even After Passing the Probabilistic Test #23102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cohnt
Copy link
Contributor

@cohnt cohnt commented Jun 16, 2025

Closes #23050. Holding off on review until #23096 lands.


This change is Reviewable

@cohnt cohnt added status: do not review release notes: feature This pull request contains a new feature labels Jun 16, 2025
@cohnt cohnt moved this to TODO (IRIS and Convex Sets) in Graphs of Convex Sets Jun 16, 2025
@cohnt cohnt force-pushed the remove-all-collisions-option branch from f8a2dd3 to b37852c Compare June 16, 2025 22:28
@cohnt
Copy link
Contributor Author

cohnt commented Jun 16, 2025

+@wernerpe for feature review.

Copy link
Contributor

@wernerpe wernerpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your use case for this option? why not just make the unadaptive test more stringent?

Reviewable status: LGTM missing from assignee wernerpe, needs platform reviewer assigned, needs at least two assigned reviewers

Copy link
Contributor Author

@cohnt cohnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change originally resulted from a stackoverflow poster having issues with IrisZo producing regions that had too many collisions -- sample GCS paths were not collision-free. Setting the fraction in collision and probability of failure to 1e-2 and 1e-3 both fail -- 1e-4 is required. But this is very slow, with some regions taking up to 100 seconds to produce. On the other hand, using 1e-2 together with this new option, kept region generation times around half a second and led to collision-free paths. So this seems like a pretty solid quality-of-life change.

Reviewable status: LGTM missing from assignee wernerpe, needs platform reviewer assigned, needs at least two assigned reviewers

@cohnt
Copy link
Contributor Author

cohnt commented Jun 17, 2025

@drake-jenkins-bot retest this please

@cohnt cohnt moved this from TODO (IRIS and Convex Sets) to In Progress in Graphs of Convex Sets Jun 17, 2025
@cohnt cohnt force-pushed the remove-all-collisions-option branch from b37852c to fb05009 Compare June 17, 2025 22:46
…n the last inner iteration, even if that iteration already passed the collision-free probabilistic test.
@cohnt cohnt force-pushed the remove-all-collisions-option branch from fb05009 to a2707ae Compare June 18, 2025 16:42
Copy link
Contributor

@wernerpe wernerpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: feature This pull request contains a new feature
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

IrisZo Option to Remove Additional Collisions Once C-Free Fraction is Met
2 participants