add option for routing_budget_ppm in /api/rewards #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryfletcher21
force-pushed
the
rewards-support-routing-budget
branch
from
02d3c94 to
3fa9222
Compare
jerryfletcher21
force-pushed
the
rewards-support-routing-budget
branch
from
3fa9222 to
e90701a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uniforms the
/api/rewardswith the/api/orderupdate_invoice(changed in #326), adding the optionrouting_budget_ppmin/api/rewards, and thus fixing #1382 for the backend.An other pull request implementing it in the frontend is needed (maybe to be incorporated in #1973). This commit still leaves the option to not specify
routing_budget_ppmin order to be compatible with old clients, with the notice in the code that it should be deprecated in the future.It also remove the
MIN_FLAT_ROUTING_FEE_LIMITvariable from.env-sample, since after #347 it is no longer used.Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.