Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter deepth chart by host #1632

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Filter deepth chart by host #1632

merged 3 commits into from
Nov 25, 2024

Conversation

KoalaSat
Copy link
Member

@KoalaSat KoalaSat commented Nov 25, 2024

What does this PR do?

Filter deepth chart by host

Screenshot from 2024-11-25 10-39-33
Screenshot from 2024-11-25 10-39-19
Screenshot from 2024-11-25 10-39-26

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

language: system
files: ^mobile/
types_or: [javascript, jsx, ts, tsx, css, markdown, json] # uses https://github.com/pre-commit/identify
entry: bash -c 'cd frontend && npm run lint'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were not running frontend linterns after-commit and I always forgot about them

@KoalaSat
Copy link
Member Author

Merging this as is to be able to use the lintern

@KoalaSat KoalaSat merged commit ce4a96b into main Nov 25, 2024
@KoalaSat KoalaSat deleted the filter-deepth-chart-by-host branch November 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant