perf(coordinator): remove avatar generator #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Robot avatar generation has moved to the frontend since v0.6.0. There is no reason anymore for the coordinator to generate and serve avatars. In addition, current coordinator-side avatars are different to those on the clients, therefore these serve no purpose in the the coordinator panel either (only place left were these are displayed), as these backend avatar can't be used to identify a robot anymore.
This PR removes definitely robot avatar generation in the coordinator:
/api/robot
auth performance, as there is no need to spend ~250-500ms assembling the.webp
images./coordinator/api/robot/
,/coordinator/authtoken/tokenproxy/
and/coordinator/auth/user/
/static
folder anymore.This is a breaking change. Any user still running clients v0.5.4 or earlier will not be able to keep using RoboSats anymore.
Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.