Simplify beforeAll handling. #117
Conversation
src/TestRunner.lua
Outdated
| for _, hook in pairs(lifecycleHooks:getAfterAllHooks()) do | ||
| runCallback(hook, "afterAll hook: ") | ||
| -- errors in an afterAll hook are currently not caught | ||
| -- or attributed to a set of child nodes | ||
| local success, errorMessage = runCallback(hook, "afterAll hook: ") | ||
| if not success then | ||
| session:addDummyError("afterAll", errorMessage) | ||
| end | ||
| end |
There was a problem hiding this comment.
Do we still want to run afterAll when there were errors in beforeAll? Is this behavior we should pin?
There was a problem hiding this comment.
I think we should still run it, since its point is to do cleanup, and you often still need that even if beforeAll failed. However, it deserves some consideration before committing to that.
There was a problem hiding this comment.
Yeah, I think we should keep this. I can't find any documentation on how jest handles this specific case, but I can easily imagine when you'd want this behavior (set up 3 things, but the last fails, you still need to clean up the other two), but I can't think of any reason not to have it.
We should also document the behavior that a failing beforeAll will stop any further code in that block except for the *All blocks at that specific level.
There was a problem hiding this comment.
Doesn't look like we have any in-depth documentation to add this to at the moment. I'll file that as a separate issue.
Make
beforeAllrun at the beginning of the block rather than waiting to run it on the firstitblock encountered. This is simpler, and also consistent with howafterAllworks. This is also necessary for adding the context object as nowbeforeAllwill run in the correct context.This change makes it so that a
beforeAllwill run even if there are noitblocks to apply it to. It also means that thebeforeAllblock is no longer tied to a specificitblock to report failures through. Instead, it now creates a dummy report node to contain any failures. As a side benefit, theafterAllblock can use this same mechanism and report failures now.