Skip to content

Update CfakeRipper to new site format (Fixes #2116) #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2025
Merged

Conversation

metaprime
Copy link
Contributor

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Cfake site changed URL and layout. This PR fixes the ripper to align with the new site layout.

Testing

Required verification:

  • I've verified that there are no regressions in gradlew test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@metaprime metaprime requested a review from Copilot April 20, 2025 02:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CfakeRipper to adapt to the site's new URL format and layout. Key changes include:

  • Updating the regex pattern to match the new URL format.
  • Modifying element selection in getNextPage to reflect the redesigned page layout.
  • Adjusting image URL transformation in getURLsFromPage to use HTTPS and convert thumbnails to full-size photos.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/java/com/rarchives/ripme/tst/ripper/rippers/CfakeRipperTest.java Updated test URL to match the new site format.
src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java Revised regex, page navigation, and image URL handling logic.
Comments suppressed due to low confidence (1)

src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java:52

  • The comment still references 'comic-nav-next' which is inconsistent with the updated element selection logic. Please update the comment to accurately describe the new navigation strategy.
// We use comic-nav-next to the find the next page

@metaprime metaprime merged commit 46ac407 into main Apr 20, 2025
8 checks passed
@metaprime metaprime deleted the issue-2116-cfake branch April 20, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CfakeRipper not working - site changed - URL format and possibly page format need updating
1 participant