Skip to content

[DOCS][BUG] match-v5 playerScore# fields are floats now, not ints (and capitalized wrong, and also duplicated) #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MingweiSamuel opened this issue Mar 7, 2025 · 0 comments
Assignees
Labels
api: match-v5 pending: acknowledged We're aware of this issue and are investigating.

Comments

@MingweiSamuel
Copy link

MingweiSamuel commented Mar 7, 2025

After wednesday's patch

match-v5.ParticipantDto.playerScore0-11 are all lowerCamel and int in the docs, but the API returns PascalCase PlasyerScore1 and values are floats. The casing issue is #1039

Similarly, match-v5.MissionsDto.playerScore0-11 are in the correct case, but docs say they are int when they are floats.

Also, the data is completely duplicated between the ParticipantDto and the MissionsDto within, see below.


Failed to get match JP1_498473890: Riot API request failed after 0 retries with status code Some(200).
Deserialization error: Something went wrong during deserialization:
- info.participants[0].PlayerScore2: invalid type: floating point `732.5479125976562`, expected i32 at line 1 column 1795
- info.participants[0].PlayerScore3: invalid type: floating point `0.3532763719558716`, expected i32 at line 1 column 1829
- info.participants[0].PlayerScore4: invalid type: floating point `-0.8999999761581421`, expected i32 at line 1 column 1864
- info.participants[0].PlayerScore5: invalid type: floating point `1428.712158203125`, expected i32 at line 1 column 1897
- info.participants[0].PlayerScore6: invalid type: floating point `3546.9150390625`, expected i32 at line 1 column 1928
- info.participants[0].PlayerScore7: invalid type: floating point `848.3316650390625`, expected i32 at line 1 column 1961
- info.participants[0].PlayerScore8: invalid type: floating point `23.0013484954834`, expected i32 at line 1 column 1993
- info.participants[0].missions.playerScore2: invalid type: floating point `732.5479125976562`, expected i32 at line 1 column 6427
- info.participants[0].missions.playerScore3: invalid type: floating point `0.3532763719558716`, expected i32 at line 1 column 6461
- info.participants[0].missions.playerScore4: invalid type: floating point `-0.8999999761581421`, expected i32 at line 1 column 6496
- info.participants[0].missions.playerScore5: invalid type: floating point `1428.712158203125`, expected i32 at line 1 column 6529
- info.participants[0].missions.playerScore6: invalid type: floating point `3546.9150390625`, expected i32 at line 1 column 6560
- info.participants[0].missions.playerScore7: invalid type: floating point `848.3316650390625`, expected i32 at line 1 column 6593
- info.participants[0].missions.playerScore8: invalid type: floating point `23.0013484954834`, expected i32 at line 1 column 6625
@MingweiSamuel MingweiSamuel changed the title [DOCS][BUG] match-v5 playerScore# fields are floats not ints, and capitalized wrong, and also duplciated [DOCS][BUG] match-v5 playerScore# fields are floats not ints (and capitalized wrong, and also duplicated) Mar 7, 2025
@MingweiSamuel MingweiSamuel changed the title [DOCS][BUG] match-v5 playerScore# fields are floats not ints (and capitalized wrong, and also duplicated) [DOCS][BUG] match-v5 playerScore# fields are floats now, not ints (and capitalized wrong, and also duplicated) Mar 7, 2025
@lucasMesquitaBorges lucasMesquitaBorges self-assigned this Mar 12, 2025
@lucasMesquitaBorges lucasMesquitaBorges added pending: acknowledged We're aware of this issue and are investigating. api: match-v5 labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: match-v5 pending: acknowledged We're aware of this issue and are investigating.
Projects
None yet
Development

No branches or pull requests

2 participants