Skip to content

fix(parser): not able to correctly parse quoted array shape and object shape key #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix(parser): not able to correctly parse quoted array shape and object shape key #74

merged 1 commit into from
Jan 9, 2024

Conversation

Yilun-Sun
Copy link
Contributor

@Yilun-Sun Yilun-Sun commented Jan 8, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Not able to correctly parse quoted array shape and object shape key

What is the new behavior?

  • Can correctly parse quoted array shape and object shape key

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Yilun-Sun Yilun-Sun changed the title fix(parser): not able to parse quoted array shape key fix: not able to parse quoted array shape key Jan 8, 2024
@Yilun-Sun Yilun-Sun changed the title fix: not able to parse quoted array shape key bugfix: not able to parse quoted array shape key Jan 8, 2024
@Yilun-Sun Yilun-Sun added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jan 8, 2024
@Yilun-Sun Yilun-Sun changed the title bugfix: not able to parse quoted array shape key fix(parser): not able to parse quoted array shape key Jan 8, 2024
@Yilun-Sun Yilun-Sun requested a review from rainx January 8, 2024 07:50
@rainx
Copy link
Contributor

rainx commented Jan 8, 2024

在 MR 中需要通过 pnpm change 命令生成相应的 changeset 文件

@Yilun-Sun Yilun-Sun force-pushed the feature/support-parse-quoted-array-shape-key branch from e65d360 to 437463e Compare January 8, 2024 08:16
@Yilun-Sun Yilun-Sun marked this pull request as draft January 8, 2024 10:02
@Yilun-Sun Yilun-Sun force-pushed the feature/support-parse-quoted-array-shape-key branch from 8390daf to dc7ee9c Compare January 8, 2024 10:17
@Yilun-Sun Yilun-Sun changed the title fix(parser): not able to parse quoted array shape key fix(parser): not able to correctly parse quoted array shape and object shape key Jan 9, 2024
@Yilun-Sun Yilun-Sun marked this pull request as ready for review January 9, 2024 01:31
@rainx rainx merged commit 0c9453c into main Jan 9, 2024
@Yilun-Sun Yilun-Sun deleted the feature/support-parse-quoted-array-shape-key branch January 9, 2024 01:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rainx rainx rainx approved these changes

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yilun-Sun @rainx