Skip to content

[v4] Add Intro Eligibility Functions to CEC Mode #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

JayShortway
Copy link
Member

Description

Manual backport of #5322 to v4.

@JayShortway JayShortway requested review from fire-at-will and a team June 25, 2025 11:30
@JayShortway JayShortway self-assigned this Jun 25, 2025
@JayShortway JayShortway added pr:other pr:force_patch Forces a patch release labels Jun 25, 2025
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@JayShortway
Copy link
Member Author

What do we think about the failing run-test-ios-14 job? Seems to need some extensive changes to even run. Mint complains with:

Error: You are using macOS 12.
We (and Apple) do not provide support for this old version.

@ajpallares
Copy link
Member

What do we think about the failing run-test-ios-14 job? Seems to need some extensive changes to even run. Mint complains with:

Error: You are using macOS 12.
We (and Apple) do not provide support for this old version.

Maybe we can do the same as here? #5256

* Use Mint 0.17.5 for `run-test-ios-14` CI job

Mint 0.17.5 is required in this case as newer versions of Mint don't support macOS 1

* new try

* test run only `run-test-ios-14`

* Revert "test run only `run-test-ios-14`"

This reverts commit 1b79454.

---------

Co-authored-by: Will Taylor <[email protected]>
@JayShortway
Copy link
Member Author

@ajpallares Thank you! Cherry-picked that one. Let's see 🤞

@JayShortway JayShortway merged commit 6e3c886 into base/4.43.6 Jun 25, 2025
24 checks passed
@JayShortway JayShortway deleted the v4-expose-intro-eligibility-to-cec-mode branch June 25, 2025 13:10
@JayShortway JayShortway mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:force_patch Forces a patch release pr:other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants