Fix paywall locale receiving UN M.49 standard localization #5309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
approved these changes
Jun 20, 2025
tonidero
approved these changes
Jun 20, 2025
| // This covers cases where dictionary keys contain the UN M.49 standard. For example: | ||
| // If locale = "es_MX" and dictionary key = "es_419" (both have rc_languageAndScript = "es-Latn") | ||
| if let onlyLanguageAndScriptIdentifier = locale.rc_languageAndScript, | ||
| let match = self.valueForLanguageAndScript(onlyLanguageAndScriptIdentifier) { |
There was a problem hiding this comment.
Not sure if it's possible/worth to add some tests for this?
There was a problem hiding this comment.
Indeed. Good point that I totally forgot about! Thank you for the suggestion!
|
Actually, I was writing a test for this and the first one I wrote did not pass func test_es_MX_Matches_es_419_ByLanguageAndScript() {
let localizations = [
"es_419": Self.expectedTranslations,
"es": ["wrong": "this is es"]
]
let locale = Locale(identifier: "es_MX")
// This tests that "es_MX" matches "es_419" due to both sharing the same language and script ("es-Latn")
let foundLocalizations = localizations.findLocale(locale)
expect(foundLocalizations).to(equal(Self.expectedTranslations))
}The reason is that I originally added the new check as a last resort (it was the last check). But that makes "es_MX" match "es" before "es_419", which is wrong. Therefore, I think the new check should happen before checking only the language identifier (done 14d3c99) Please lmk if you think otherwise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found a bug where displaying a paywall with the only Spanish localization being
"es_MX"would not show some localization strings (device region: Spain, preferred languages: es, en_US)Description
In this case, the server's
ui_config.localizationcontains"es_419"(UN M.49 standard for the Latin America and the Caribbean region) but no"es_MX". With the existing implementation, the SDK was not able to match"es_MX"with"es_419".This PR adds an extra step when trying to find the matching locale from
UIConfig.localizations. As a last resort, it tries to find a key inui_config.localizationwith matching language and script.