Generate Mac Catalyst screenshots of Paywall components to be sent to EmergeTools #5303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just testing how Emerge will handle Mac variants.
📸 Snapshot TestBase build not foundNo build was found for the base commit f3405d8. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
…lly running in the correct environment.
…e call te emerge.
…alls/test-preview
…losely to previous version that was working as possible.
…p bundle to run iPad/iPhone app on Mac.
…eing included in EmergeTools prevew.s
Hoping that this will help Emerge pick up the test filtering on the server.
Without this, we are getting unexpected internal StoreKit previews in our builds.
joshdholtz
force-pushed
the
mac-paywalls/test-preview
branch
from
f064fbe to
3a3ac5e
Compare
|
@clindsay3 FYI, I just rebased this from |
joshdholtz
approved these changes
Jul 8, 2025
Comment on lines
+80
to
+98
| if #available(iOS 14.0, *), isiOSAppOnMac { | ||
| switch UIDevice.current.userInterfaceIdiom { | ||
| case .phone: | ||
| return "iPhone App on Mac" | ||
| case .pad: | ||
| return "iPad App on Mac" | ||
| default: | ||
| return "Unexpected iOS App on Mac" | ||
| } | ||
| } else { | ||
| switch UIDevice.current.userInterfaceIdiom { | ||
| case .mac: | ||
| return "Mac Catalyst Optimized for Mac" | ||
| case .pad: | ||
| return "Mac Catalyst Scaled to iPad" | ||
| default: | ||
| return "Unexpected Platform on Mac Catalyst" | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a crazy switch but it makes sense 😀
Tests/TestingApps/PaywallsTester/PaywallsTesterTests/PaywallsTesterTests.swift
Outdated
Show resolved
Hide resolved
ajpallares
approved these changes
Jul 8, 2025
Sources/LocalReceiptParsing/Helpers/ProcessInfo+Extensions.swift
Outdated
Show resolved
Hide resolved
Tests/TestingApps/PaywallsTester/PaywallsTester.xcodeproj/project.pbxproj
Show resolved
Hide resolved
Tests/TestingApps/PaywallsTester/PaywallsTesterTests/PaywallsTesterTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Antonio Pallares <[email protected]>
…chases-ios into mac-paywalls/test-preview # Conflicts: # Sources/LocalReceiptParsing/Helpers/ProcessInfo+Extensions.swift # fastlane/Fastfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to support Mac Catalyst for Paywall V2, we need to have a mechanism to verify the correctness of all components. This will also provide a quantifiable roadmap towards implementation of support for Mac Catalyst, since we can check off which components are working properly.
Description