Skip to content

Add abbrev to Gemfile #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Add abbrev to Gemfile #5207

merged 2 commits into from
Jun 12, 2025

Conversation

facumenzella
Copy link
Contributor

Motivation

Seems like abbrev is no longer included in the default gems for ruby 3.4.0

$PATH/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/highline-2.0.3/lib/highline.rb:17: warning: 

abbrev was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.

@facumenzella facumenzella requested review from a team May 30, 2025 08:47
@facumenzella facumenzella changed the title Add abbrev to Gemfile for ruby Add abbrev to Gemfile May 30, 2025
@facumenzella facumenzella requested a review from ajpallares June 12, 2025 11:54
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

I was thinking about whether we needed to update the CI cache. But we do not because the Getfile.lock hash is already part of the cache key

- v4-gem-cache-{{ checksum "Gemfile.lock" }}-{{ arch }}-ruby-3.2.0

All good I'd say 👍

@facumenzella facumenzella merged commit f0ce0e2 into main Jun 12, 2025
12 checks passed
@facumenzella facumenzella deleted the other/ruby-abbrev branch June 12, 2025 13:27
facumenzella added a commit that referenced this pull request Jun 13, 2025
facumenzella added a commit that referenced this pull request Jun 13, 2025
* refactor history view

* tests

* update hash

* donbe

* lint

* lint

* mocks

* redo mocks

* fixed tests

* mocks

* delete yearly

* purchase hist

* fixed snap

* delete extra intialiser parameter

* Renamed isActive to isExpired (#5261)

* Add badge cancelled trial to PurchaseCardView (#5262)

* Renamed isActive to isExpired

* Add badge cancelled trial

* missing default key

* missing default key

* isExpired

* Version bump for 5.28.1 (#5271)

* Preparing for next version (#5272)

* Add _spi(Internal) to Customer Center (#5270)

* Add _spi(Internal) to costumer center

* add missing spi

* Add _spi(Internal) to costumer center

* add extra spi

* missing spi

* missing spi

* add missing spi

* fix bad merge

* Update Sources/CustomerCenter/CustomerCenterConfigData.swift

* Add abbrev to Gemfile (#5207)

* Delete duplicate OfferingsList.swift from PaywallTester (#5249)

* removed

* using customer info

* added exp date and renewal date

* added exp date and renewal date

---------

Co-authored-by: RevenueCat Git Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants