Skip to content

fix(YouTube - Slide to seek): Show tap and hold 2x speed overlay when active #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LisoUseInAIKyrios
Copy link
Contributor

If "Slide to seek" is enabled, 2x tap and hold still works before touch sliding left/right.

This change removes the logic that hides the "2x speed" overlay that is active, since 2x does initially still work.

But most importantly, the logic to hide the overlay broke in a recent app update. The opcode pattern started matching a completely different section of code that is unrelated to the overlay, and the code appears to be for collecting devices thermal status statistics. It's unclear the code is only for statistics or if it could actually doing anything else.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit dbc9c5f into ReVanced:dev Jul 10, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/slide_to_seek_overlay_text branch July 10, 2025 13:35
github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
# [5.31.0-dev.13](v5.31.0-dev.12...v5.31.0-dev.13) (2025-07-10)

### Bug Fixes

* **YouTube - Slide to seek:** Show tap and hold 2x speed overlay when active ([#5398](#5398)) ([dbc9c5f](dbc9c5f))
github-actions bot pushed a commit that referenced this pull request Jul 11, 2025
# [5.31.0](v5.30.0...v5.31.0) (2025-07-11)

### Bug Fixes

* **Bacon Reader - Spoof client:** Use www instead of ssl API to fix auth related issues  ([#5402](#5402)) ([72459bb](72459bb))
* Correctly name `Enable ROM signature spoofing` patch ([d85881a](d85881a))
* Fix accidental changes ([e2ac841](e2ac841))
* Fix refactoring typo ([ec0ae42](ec0ae42))
* Handle empty list of announcements ([de9d720](de9d720))
* **SoundCloud:** Constrain patches to last working app target ([e8ea89f](e8ea89f))
* **Spotify - Unlock Premium:** Remove wrongfully hidden non ad browse sections ([#5403](#5403)) ([8633544](8633544))
* **Spotify:** Remove other ads type from the browse screen ([#5333](#5333)) ([c68533a](c68533a))
* **Sync for Reddit - Spoof client:** Use www instead of ssl API to fix auth related issues ([#5392](#5392)) ([47e6b62](47e6b62))
* **YouTube - Hide ads:** Hide new type of general ad ([#5345](#5345)) ([f23716b](f23716b))
* **YouTube - Hide layout components:** Do not hide playlist sort button if 'Hide AI comments summary' is on ([5f3e48e](5f3e48e))
* **YouTube - Playback speed:** Allow custom speeds with 0.01x precision ([#5360](#5360)) ([0eecef0](0eecef0))
* **YouTube - Slide to seek:** Show tap and hold 2x speed overlay when active ([#5398](#5398)) ([dbc9c5f](dbc9c5f))

### Features

* **Cricbuzz - Hide ads:** Hide Cricbuzz11 UI elements ([#5381](#5381)) ([a42c98f](a42c98f))
* **Lightroom:** Constrain patches to last working version ([#5335](#5335)) ([32ce70e](32ce70e))
* **Spotify - Spoof client:** Fix issues like songs skipping by spoofing to iOS ([#5388](#5388)) ([e36d4c1](e36d4c1))
* **Spotify:** Remove support for old versions ([#5404](#5404)) ([9d31238](9d31238))
* **YouTube - Change header:** Add in-app setting to change the app header ([#5346](#5346)) ([9ba45b6](9ba45b6))
* **YouTube - Hide layout components:** Add `Hide channel links preview` and `Hide 'Visit Community' button` in channel page ([#5320](#5320)) ([9d9cce3](9d9cce3))
* **YouTube:** Disable two-finger tap gesture for skipping chapters ([#5374](#5374)) ([71db0a2](71db0a2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant