Fixed #222 - Separation pluginManagement/plugins #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khmarbaise
commented
May 1, 2025
khmarbaise
commented
- Moved life cycle binding to plugins instead of pluginManagement.
- Removed other plugins which are bound by default via life cycle.
- Moved life cycle binding to plugins instead of pluginManagement. - Removed other plugins which are bound by default via life cycle.
Randgalt
reviewed
May 2, 2025
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-source-plugin</artifactId> | ||
| <executions> |
There was a problem hiding this comment.
I've always put this in the pluginManagement. Why should it be here out of curiosity?
There was a problem hiding this comment.
Technically it is working in pluginManagement, but I recommend to separate the configuration/version definition of plugins... in dependencyManagement... and in build do the bindings to a life cycle....
There was a problem hiding this comment.
For me, having it in pluginManagement is more, well, manageable :D I prefer to leave it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.