Add support for SEQURE S99, and new Rev. of S60P #1920

jonasius · 2024-05-26T20:57:26Z

Please check if the PR fulfills these requirements

The changes have been tested locally
There are no breaking changes

What kind of change does this PR introduce?

Add support for Sequre S99

What is the new behavior (if this is a feature change)?
IronOS booting on Sequre S99
Other information:
Currently work in progress.

Problems / Todo

Startup is slow, black screen for a few seconds, maybe due to PD negotiation issues?
Negotiation of PD seems to have a problem. Tested with multiple Apple USB-C Chargers.Always uses 5V QC. PD Debug at startup shows State 0 0 21 multiple times, with blinking/resetting screen, after a while showing State 4 1 21.
OP_AMP_GAIN_STAGE 536 needs to be adjusted according to the 22k resistor instead of 51k
Documentation needs to be updated
Maybe source/Code/BSP/Sequre_S60 folder should be renamed to Sequre?
Better thermo model for tip temperature measurement?
Tip selection option to allow usage of 5.5 Ohm tips?

source/Core/BSP/Sequre_S60/configuration.h

source/Core/Drivers/Font.h

Co-authored-by: discip <[email protected]>

Ralim · 2024-06-01T06:28:44Z

Hia,

This is great progress.

The black screen at startup is odd. PD negotiation shouldn't block boot. Is it possible its being restarted rapidly with flaky USB-PD?

(Do you have any tools for debugging USB-PD)?

I haven't really worked on the FS2711 driver much so not sure how best to debug it other than trying to parse the code to match up to what you see.

jonasius · 2024-06-01T06:42:28Z

Hey, yeah. It seems to restart rapidly. It seems to be especially with the Apple Chargers. Another charger I tried let the iron boot straight up.
I hope I can investigate further this weekend.

Sadly I don't have special USB-PD tools. Maybe I need to get something or build something to hook a logic analyzer on?

As I could see with the debug menu, when it comes up it gets all available PD modes, but stays in 5V mode. I think I need to take a look at the measurement of the tip for the power calculation? Maybe you can give me a hint on that?

jonasius · 2024-06-01T22:50:34Z

@Ralim I'm currently digging a bit through the code and debug outputs of the iron. I wondered why it reports PWR QC instead of PWR PD. I think at least I need to extend the getPowerSourceNumber funciton with a ifdef for POW_PD_EXT.

Regarding the PD negotation problem with my Apple 60W USB-C PSUs I tried to increase the PROTOCOL_TIMEOUT to 200 ms, which helped. The Iron boots instantly. PD Debug First Shows State 0 0 21 but quickly changes to State 4 1 21, without a reset/screen flicker. What I noticed when I switched through the PD debug menu and viewed the capabilities was that before increasing the timeout, the PD debug menu showed an entry with no voltage and only amps specified. That entry isn't showing up with the increased timeout.

I hope I can make some progress tomorrow.

Ralim · 2024-06-02T08:30:26Z

I'm currently digging a bit through the code and debug outputs of the iron. I wondered why it reports PWR QC instead of PWR PD. I think at least I need to extend the getPowerSourceNumber funciton with a ifdef for POW_PD_EXT.

Ah heck, yes that will fix the issue

PROTOCOL_TIMEOUT should have been wired up to the PD timeout we already have thats user adjustable.
If you want I can wire that up (or you can of course). I default to 500ms for normal pd.

jonasius · 2024-06-02T21:27:00Z

PROTOCOL_TIMEOUT should have been wired up to the PD timeout we already have thats user adjustable. If you want I can wire that up (or you can of course). I default to 500ms for normal pd.

@Ralim It's a bit unclear to me. In the Settings.cpp PDNegTimeout default value is 20, max 50. If I got the description right it should be in 100ms steps, so default is 2000ms? :-o

OP_AMP_GAIN_STAGE 536 needs to be adjusted according to the 22k resistor instead of 51k

How did you determined the value for the OP_AMP_GAIN_STAGE? ~~I measured/calculated it roughly to 226 for the different feedback resistor. I don't get exactly how the two OP-Amps are connected.~~

Ralim · 2024-06-04T08:32:22Z

so default is 2000ms? :-o

Ah sorry, I think we raised the default later on.

How did you determined the value for the OP_AMP_GAIN_STAGE
This number is calculated as being the "gain" of the op-amp.

In the S60, its two sequential op-amps chained.
Both are configured as non-inverting amplifiers.

Input op-amp has feedback resistors of 9.31K and 1K. (therefore gain is 10.31)
Second op-amp has feedback resistors of 51K and 1K. (therefore gain is 52).

So 10.31 * 50 = 536.12; so the define is set to 536

* Enable PD Options * Make PDNegTimeout configureable * Add default value for PDNegTimeout, also for S60 and S60P * Add basic DC detection / correct debug readings while powered via DC * Add basic ThermoModel for C245 Tips * Modify op-amp gain

Ralim · 2024-06-08T04:34:50Z

source/Core/BSP/Sequre/Power.cpp

-bool getIsPoweredByDCIN() { return false; }
+bool getIsPoweredByDCIN() {
+#if POW_PD_EXT == 2 && defined(POW_DC)
+  if (!FS2711::has_run_selection()) {


source/Core/BSP/Sequre/configuration.h

Ralim

This seems sane to me at a read.

Ralim · 2024-06-08T04:44:33Z

Let me know when you are happy with this by marking it ready for review 🙇🏼

jonasius · 2024-06-10T20:27:58Z

Let me know when you are happy with this by marking it ready for review 🙇🏼

Nice!
I'll try to fine tune the temperature coefficient beforehand. Add documentation / the S90 to the supported irons table and fix the remaining clang style mismatches.

jonasius · 2024-06-19T20:44:58Z

I compared the temperature at a setpoint of 320°C to a original JBC station. In my eyes the coefficient is okay for a first shot.

Then I observed that the name and description for PDNegTimeout and USBPDMode are not shown in the menu. I quite don't get it. The menu Item is here

I got a second S99 which is V1.5 instead of V1.4, it seems that they changed something. Although a FS2711 is used, it does not negotiate PD. I quickly took two picutes:

jonasius · 2024-06-22T14:52:52Z

@Ralim, I tried your increased pwm speed. Works great on the S99! No more restarts, even with power limit set to 60W on a 60W USB-C charger.

What I got so far regarding v1.5

There is a detection of HW version in the original FW
I2C to the FS2711Q connection seems to use the same pins
Just to make sure I checked the bootloader, it is also the same on the v1.5 iron
PD-Debug shows only zeros

Ralim · 2024-11-21T10:06:38Z

Hmm; PPS evaluation could be involved, it would be my rough guess as its probably the pain part of the protocol. Is it possible to disable PPS for testing?

discip · 2024-11-21T10:30:44Z

@Ralim
With the mentioned charger (Anker Nano II 65W) I need PPS to use the S60P to its full potential, since the fixed 12V option is missing. 😅

But for testing purposes this could be disabled.

jonasius · 2024-11-28T22:07:18Z

@discip I've quickly put together a fw which shows the i2c devices it can find on startup instead of the usb-pd menu. Maybe you could flash it and enter the usb-pd debug menu. It should show numbers on the left and right side of the screen.
s60p_probing_test.zip

discip · 2024-11-29T13:40:33Z

@jonasius
Thank you.

Here are the numbers:

090	090
091	091
120	120
121	121

jonasius · 2024-11-29T17:34:07Z

@discip okay, thats good, 90 is there as expected.
Could you try the following:
s60p_probing_startwith90.zip
and maybe that one:
s60p_probing_delay_startwith90.zip

discip · 2024-11-29T20:48:26Z

@jonasius
s60p_probing_startwith90.zip

091	090
120	091
121	120
122	121

s60p_probing_delay_startwith90.zip

091	090
120	091
121	120
122	121

jonasius · 2024-11-29T20:51:22Z

@discip
Ah, nice. We are getting closer :) So we may need more delay.
Please try this... s60p_probing_startwith89.zip

discip · 2024-11-29T21:59:16Z

@jonasius
Same as here:

Here are the numbers:

090 090
091 091
120 120
121 121

jonasius · 2024-12-06T23:19:11Z

@discip that version should be able to communicate with the pd-ic. I'm not happy with the solution. Maybe one probe before the real probing should be enough.

discip · 2024-12-07T00:13:05Z

@jonasius
Thank you for not giving up! 😃👍

Unfortunately now is says:

PD Debug
State 1

allowing only 5.2 V

jonasius · 2024-12-08T08:03:16Z

@discip just for clarification. The latest build of dev branch negotiates with 12V?!

discip · 2024-12-09T22:16:18Z

@discip just for clarification. The latest build of dev branch negotiates with 12V?!

Sorry, I'm not able to follow here. What exactly is this supposed to tell me? 😊

jonasius · 2024-12-09T22:39:38Z

@discip just for clarification. The latest build of dev branch negotiates with 12V?!

Sorry, I'm not able to follow here. What exactly is this supposed to tell me? 😊

Sorry.
What's the PD-Debug output with the latest build of the dev branch? For example this one:
https://github.com/Ralim/IronOS/actions/runs/12233892729/artifacts/2293020834

discip · 2024-12-11T21:36:39Z

@jonasius
With the provided build the screen reads:

PD Debug
State 6

Nothing else (There is no option I can go through like e.g. with the Pinecil).

And it negotiates for 8.3 V.

RodoMa92 · 2024-12-22T11:50:32Z

Just tested on my new S99 after my Pinecil V1 USB PD decided to die on me, seems to work decently. Haven't tested a lot, though. Thanks a lot for your work! I'll see if I can RE the schematics of it, to be able to properly fix it in case.

safocl · 2025-02-02T07:45:41Z

source/Core/BSP/Sequre/Software_I2C.h


+#ifdef I2C_SOFT_BUS_1


Why insert a check here? The names of the entities are different anyway.
(SOFT_SCL1_HIGH and SOFT_SCL2_HIGH respectively)

discip · 2025-03-08T22:42:30Z

@Ralim
Would you mind having a look into this. If you have time that is.
It still doesn't work as intended.

Ralim · 2025-03-29T01:38:22Z

@discip Sorry I haven't followed this for a bit, what is and isn't working anymore on this?

jonasius · 2025-03-29T07:45:26Z

I really want to bring this forward.

One option would be that we create separate files for each hw revision of s99 and s60p. Probably the easiest solution. What do you think @Ralim @discip ?

Option two, if @discip is located in the EU and is willing to send me his hardware I could investigate further and try to solve the issue.

RodoMa92 · 2025-03-30T11:37:47Z

I do have issues with PD bootlooping the iron on specific chargers (mainly QC compatible, I can post a PD detection image later),PD state keep bouncing between 0 and 1 really quickly, that do not happen with the original firmware. On the Steam Deck charger however it does seems to behave correctly.

Ralim · 2025-03-30T23:56:16Z

@jonasius

What's the hard requirement for having to split hardware revisions?
So far the rule has been that the user has to be able to know the file based on what is written on the device, as otherwise we will get issues from people flashing the wrong file.

schinken · 2025-06-30T08:12:25Z

Can we somehow have a new build in GH Actions so we can try the latest?

jonasius · 2025-06-30T08:17:58Z

@jonasius

What's the hard requirement for having to split hardware revisions?

I'll update it later.

schinken · 2025-07-08T07:30:13Z

@jonasius sadly no new build. Is this because of requested changes?

jonasius · 2025-07-08T07:46:56Z

Sorry, had little time lately. I have to figure out why the build breaks. I'm working on it.

jonasius added 3 commits May 26, 2024 21:13

Add support for Sequre S99, copied S60P settings

653a080

Add S99

1521b5e

Add Sequre S99 with correct bootloader offset

a3b7abb

discip requested changes May 26, 2024

View reviewed changes

source/Core/BSP/Sequre_S60/configuration.h Outdated Show resolved Hide resolved

source/Core/Drivers/Font.h Outdated Show resolved Hide resolved

jonasius and others added 2 commits May 26, 2024 23:09

Add whitespaces according to coding style

5ea42a8

Co-authored-by: discip <[email protected]>

Add whitespaces according to coding style

2c5d2a0

Co-authored-by: discip <[email protected]>

Merge branch 'Ralim:dev' into dev

a306de5

jonasius added 2 commits June 2, 2024 16:15

Correct debug menu "Tip R" to "Tip uV"

e327be5

Use SettingsOptions::PDNegTimeout in FS2711 driver

a2615a5

Correct debug menu "Tip R" to "Tip uV"

31ff398

jonasius added 5 commits June 6, 2024 20:27

Rename Sequre_S60 folder to Sequre

6e53d85

Support for S99

6ef1fbd

* Enable PD Options * Make PDNegTimeout configureable * Add default value for PDNegTimeout, also for S60 and S60P * Add basic DC detection / correct debug readings while powered via DC * Add basic ThermoModel for C245 Tips * Modify op-amp gain

Add define for USB_PD_TIMEOUT, the default value for PDNegTimeout

da28492

Add define for USB_PD_TIMEOUT, the default value for PDNegTimeout

f5d6d8b

Fix clang-format code style mismatches

8514edf

Ralim reviewed Jun 8, 2024

View reviewed changes

source/Core/BSP/Sequre/configuration.h Show resolved Hide resolved

Ralim approved these changes Jun 8, 2024

View reviewed changes

jonasius added 2 commits June 19, 2024 22:05

Add S99 to overview table

b772e1d

Fix clang-format code style mismatches

c8c36d2

jonasius and others added 2 commits December 6, 2024 23:51

Add probing for unused devices for testing/timing

02580da

Merge branch 'dev' into dev

867f1fc

Merge branch 'dev' into dev

a5560ae

safocl reviewed Feb 2, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/dev' into dev

69c5935

Merge branch 'dev' into dev

c5dc83a


		#ifdef I2C_SOFT_BUS_1

Uh oh!

Add support for SEQURE S99, and new Rev. of S60P #1920

Are you sure you want to change the base?

Add support for SEQURE S99, and new Rev. of S60P #1920

Conversation

jonasius commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problems / Todo

Uh oh!

Uh oh!

Uh oh!

Ralim commented Jun 1, 2024

Uh oh!

jonasius commented Jun 1, 2024

Uh oh!

jonasius commented Jun 1, 2024

Uh oh!

Ralim commented Jun 2, 2024

Uh oh!

jonasius commented Jun 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ralim commented Jun 4, 2024

Uh oh!

Ralim Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ralim left a comment

Choose a reason for hiding this comment

Uh oh!

Ralim commented Jun 8, 2024

Uh oh!

jonasius commented Jun 10, 2024

Uh oh!

jonasius commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasius commented Jun 22, 2024

Uh oh!

Ralim commented Nov 21, 2024

Uh oh!

discip commented Nov 21, 2024

Uh oh!

jonasius commented Nov 28, 2024

Uh oh!

discip commented Nov 29, 2024

Uh oh!

jonasius commented Nov 29, 2024

Uh oh!

discip commented Nov 29, 2024

Uh oh!

jonasius commented Nov 29, 2024

Uh oh!

discip commented Nov 29, 2024

Uh oh!

jonasius commented Dec 6, 2024

Uh oh!

discip commented Dec 7, 2024

Uh oh!

jonasius commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

discip commented Dec 9, 2024

Uh oh!

jonasius commented Dec 9, 2024

Uh oh!

discip commented Dec 11, 2024

Uh oh!

RodoMa92 commented Dec 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

safocl Feb 2, 2025

Choose a reason for hiding this comment

Uh oh!

discip commented Mar 8, 2025

Uh oh!

Ralim commented Mar 29, 2025

Uh oh!

jonasius commented Mar 29, 2025

jonasius commented May 26, 2024 •

edited

Loading

jonasius commented Jun 2, 2024 •

edited

Loading

jonasius commented Jun 19, 2024 •

edited

Loading

jonasius commented Dec 8, 2024 •

edited

Loading

RodoMa92 commented Dec 22, 2024 •

edited

Loading