Issue1545 conditionality of corGMod and simpleExternalShading #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….ThermalZones.ReducedOrder.ThermalZone.ThermalZone
|
@FWuellhorst again, I can't ask for a review via the GitHub functionality, and also can't initialize the CI. |
PGorzalka
changed the title
FWuellhorst
approved these changes
May 6, 2025
|
Still can't merge it by myself @FWuellhorst ;) |
|
@PGorzalka I added you as an outside collaborator to RWTH-EBC. Please check if it is now possible. Especially if you also aim to contribute to AixWeather, you may need this! Thanks for your contributions! |
|
Thanks :) Membership worked, but there is still no merge button here. |
|
Now? :) |
|
Thanks! I guess the branch should be deleted? |
|
Yes, you can delete the branch in your fork. The one in AixLib was removed by me already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #1545
I did not run the full unit tests, as the two lines that were removed will not affect any of them. Checked two of the Multizone examples anyway, they are working fine.