-
Notifications
You must be signed in to change notification settings - Fork 80
Issue1223 new storage examples #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@LauraMaier |
…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1223_NewStorageExamples/plots/
Errors in regression test. Compare the results on the following page |
I removed the review request from @MZuschlag to speed up the process now even though the review so far was very helpful! :-) |
Errors in regression test. Compare the results on the following page |
…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1223_NewStorageExamples/plots/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LauraMaier You somehow deleted the renamed files instead of renaming them. Please change this to keep the file history intact.
AixLib/Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageBoiler.mos
Outdated
Show resolved
Hide resolved
…H-EBC/AixLib into issue1223_NewStorageExamples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local rename does not work for me. I guess one has to do it directly in the correct way, as git already had a history on StorageDetailedBaseDataDefinition
now.
But I mean it's not that important!
Thanks for your work. Now let's wait for HTML
…NewStorageExamples [skip ci]
…ion reference files. Please pull the new files before push again. Plottet Results /issue1223_NewStorageExamples/charts/
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
…ion reference files. Please pull the new files before push again. Plottet Results /issue1223_NewStorageExamples/charts/
…H-EBC/AixLib into issue1223_NewStorageExamples
This closes #1223