Skip to content

JOSS review: Building vignettes fails when installing from GitHub #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kanishkan91 opened this issue Jun 5, 2023 · 3 comments
Closed

JOSS review: Building vignettes fails when installing from GitHub #10

kanishkan91 opened this issue Jun 5, 2023 · 3 comments

Comments

@kanishkan91
Copy link

When I tried devtools::install_github("EpiVec/TDLM", build_vignettes = TRUE) with the build_vignettes set to TRUE, installation failed.

However, if that is set to FALSE, the package installs fine. Adding the error below-

image

openjournals/joss-reviews#5434
maximelenormand added a commit that referenced this issue Jun 5, 2023
@maximelenormand
Update README (#4), DESCRIPTION (#10) and vignettes (#11)
f3f4f6f
@maximelenormand
Copy link
Member

It seems that you are using an old version of write_delim in which the "progress" argument is not available. To prevent this I added a minimal version requirement for readr in the DESCRIPTION.

@maximelenormand
Copy link
Member

I added a minimal version requirement for every dependency in DESCRIPTION.

@kanishkan91
Copy link
Author

Thanks. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximelenormand @kanishkan91