GUI/SaveState: Progress Dialog On Save State Creation, Saving Fixes And Speed Improvement #15345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
get-rid
branch
2 times, most recently
from
fee5f60 to
25b6235
Compare
elad335
force-pushed
the
get-rid
branch
2 times, most recently
from
db3feb1 to
1611d9a
Compare
elad335
changed the title
elad335
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savestate creation is relatively long due to compression, it makes some users think savestates do not work or that RPCS3 crashed. So I propose for now a progress dialog for savestate creation which shows how much time passed and how many bytes were written.
The percentage shown is not accurate and is an estimation of the amount of bytes written, never actually reaching 100% before completion in order to simplify the implementation. 300MB = 50%, 600MB = 75%, 1200MB = 87.5%, most games will quit saving at around 50%.