Skip to content

At education courses and summer school SDU #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

knmcguire
Copy link
Member

@knmcguire knmcguire commented Nov 18, 2024

@knmcguire knmcguire requested a review from TOTON95 November 18, 2024 19:00
Copy link
Contributor

@TOTON95 TOTON95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good in general, just have a question with a sentence in particular.

Copy link
Contributor

@TOTON95 TOTON95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 🙌🏼

@TOTON95
Copy link
Contributor

TOTON95 commented Nov 18, 2024

We can merge 👍🏼

@TOTON95 TOTON95 merged commit d9bbe77 into main Nov 18, 2024
@knmcguire
Copy link
Member Author

Thank you! Let's add the link checker to the CI as well at one point :) We could do a weekly test or something?

@knmcguire knmcguire deleted the Add-education-and-summerschools-SDU branch November 21, 2024 11:40
@knmcguire
Copy link
Member Author

Ah woops sorry this is the other PR. Spoke too soon! I'll wait until you are done with PR #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants