[DO NOT MERGE!!!] Introduce tilesPerWarp parameter, scale preshuffling and bypassingLDS #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglx13
reviewed
May 25, 2025
| @@ -674,6 +654,8 @@ LinearLayout mfmaDotToLinearLayout(DotOperandEncodingAttr dotMfmaLayout, | |||
| auto kDim = dotMfmaLayout.getOpIdx() == 0 ? rank - 1 : rank - 2; | |||
| int32_t kSize = shape[kDim]; | |||
| auto warpsPerCTA = mfmaLayout.getWarpsPerCTA(); | |||
| auto tilesPerWarp = mfmaLayout.getTilesPerWarp(); | |||
| auto tilePerWarpNonK = tilesPerWarp[kDim]; | |||
There was a problem hiding this comment.
this tilesPerWarp is for mfmaLayout, which does not have "kDim". Can you be more specific here?
zhanglx13
reviewed
May 25, 2025
| auto regs = mlir::triton::identityStandardND(kRegister, {1, 1}, order); | ||
| LinearLayout lanes = LinearLayout::empty(); | ||
| auto kDim = dotOperandIdx == 0 ? rank - 1 : rank - 2; | ||
| auto tilePerWarpNonK = tilesPerWarp[kDim]; |
There was a problem hiding this comment.
here we are dealing with operands and there is kDim and nonKDim. If you need nonKDim, you should use tilesPerWarp[nonKDim]
antiagainst
force-pushed
the
shared/triton-gfx950-launch
branch
from
77c00fa to
a259f0a
Compare
plognjen
force-pushed
the
shared/preshuffle-scales-new
branch
from
f259473 to
7edf97c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.