Skip to content

Fix use of undefined member m_engine_size (#513). #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix use of undefined member m_engine_size (#513). #514

merged 1 commit into from
Jul 9, 2024

Conversation

anjenner
Copy link
Contributor

@anjenner anjenner commented Jul 3, 2024

Fix #513 .

@stanleytsang-amd
Copy link
Collaborator

Looks good to me, waiting for CI checks to pass.

@ronlieb
Copy link

ronlieb commented Jul 9, 2024

@stanleytsang-amd can this be landed ?

@stanleytsang-amd
Copy link
Collaborator

All tests pass, looks good to me. Merging.

@stanleytsang-amd stanleytsang-amd merged commit 2d549a1 into ROCm:develop Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of undefined member m_engine_size in library/src/rng/xorwow.hpp
3 participants
@anjenner @stanleytsang-amd @ronlieb