Handle const and reference scan accumulator types #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently updated the default accumulator types for rocprim::inclusive_scan, deterministic_inclusive_scan, exclusive_scan, and deterministic_exclusive_scan. The update set the default type to the return type of the scan operator. The scan operator can return a type that is const or a reference. This is problematic because internally, the scan algorithm need to create instances of the accumulator type and periodically update their value. It also needs to create pointers of the accumulator type. This change fixes the problem by stripping any const or reference from the accumulator type before it is passed to the internal scan implementation function.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
stanleytsang-amd
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated the default accumulator types for rocprim::inclusive_scan, deterministic_inclusive_scan, exclusive_scan, and deterministic_exclusive_scan.
The update set the default type to the return type of the scan operator. The scan operator can return a type that is const or a reference. This is problematic because internally, the scan algorithm need to create instances of the accumulator type and periodically update their value. It also needs to create pointers of the accumulator type.
This change fixes the problem by stripping any const or reference from the accumulator type before it is passed to the internal scan implementation function.