Change device scan default accumulator type #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default accumulator types are changing for ROCm 7.0 as described below.
Note that this is a breaking change.
* rocprim::inclusive_scan
* previous default: class AccType = typename std::iterator_traits<InputIterator>::value_type>
* new default: class AccType = rocprim::invoke_result_binary_op_t<typename std::iterator_traits<InputIterator>::value_type, BinaryFunction>`
* `rocprim::deterministic_inclusive_scan
* previous default: class AccType = typename std::iterator_traits<InputIterator>::value_type>`
* new default: class AccType = rocprim::invoke_result_binary_op_t<typename std::iterator_traits<InputIterator>::value_type, BinaryFunction>`
* `rocprim::exclusive_scan
* previous default: class AccType = detail::input_type_t<InitValueType>>
* new default: class AccType = rocprim::invoke_result_binary_op_t<rocprim::detail::input_type_t<InitValueType>, BinaryFunction>
* `rocprim::deterministic_exclusive_scan
* previous default: class AccType = detail::input_type_t<InitValueType>>
* new default: class AccType = rocprim::invoke_result_binary_op_t<rocprim::detail::input_type_t<InitValueType>, BinaryFunction>
umfranzw
requested review from
a team,
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
spolifroni-amd
requested changes
Apr 25, 2025
This fix corrects some grammatical issues in the changelog.
spolifroni-amd
approved these changes
Apr 28, 2025
Update the inclusive and exclusive host scan routines so they use the new accumulator type defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default accumulator types are changing for ROCm 7.0 as described below. Note that this is a breaking change.