Fix SWDEV-473314 by avoiding empty unique_ptr dereference

[jamesxu2]

• Revert part of blamed commit modifying source/lib/omnitrace/library/components/roctracer.cpp with goal of "clear roctracer_data storage if roctracer not initialized"
• Particularly, I don't think tim::storage<comp::roctracer_data>::instance() returns the instance of the storage singleton if it exists, but rather creates an empty unique_ptr to the storage type

[jamesxu2]

I can clarify my statement about "tim::storagecomp::roctracer_data::instance()": This instance() function uses specialized templates and calls into the wrong (generic) version yielding a false positive signal that "there is still roctracer_data that needs to be destroyed in the storage singleton".

File src: source\lib\omnitrace\library\thread_data.hpp

    

// Generic Template, which is being called and returns a pointer to uninitialized structure
template <typename Tp, typename Tag, size_t MaxThreads>
unique_ptr_t<thread_data<std::optional<Tp>, Tag, MaxThreads>>&
thread_data<std::optional<Tp>, Tag, MaxThreads>::instance()
{
    static auto _v = unique_ptr_t<this_type>{};
    return _v;
}


// Specialized Template, which you want to call but is not used. Returns a pointer to the singleton
template <typename Tp, typename Tag, size_t MaxThreads>
unique_ptr_t<Tp>&
thread_data<Tp, Tag, MaxThreads>::instance()
{
    return instances().at(threading::get_id());
}