Skip to content

Fix LD_PRELOAD #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix LD_PRELOAD #184

merged 1 commit into from
Oct 21, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • __libc_start_main in libomnitrace-dl wasn't wrapping bc of -fvisibility=hidden
  • fix OMNITRACE_STRIP_TARGET
  • omnitrace_reset_preload function in main library
  • defer removing libomnitrace from LD_PRELOAD

@jrmadsen jrmadsen added libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library cmake Modifies the CMake build system omnitrace-sample Involves the omnitrace-sample executable labels Oct 21, 2022
@jrmadsen jrmadsen force-pushed the fix-sampling-ld-preload branch from 242f603 to 86af929 Compare October 21, 2022 12:26
- __libc_start_main in libomnitrace-dl wasn't wrapping bc of -fvisibility=hidden
- fix OMNITRACE_STRIP_TARGET
- omnitrace_reset_preload function in main library
- defer removing libomnitrace from LD_PRELOAD
@jrmadsen jrmadsen force-pushed the fix-sampling-ld-preload branch from 86af929 to ed74ef4 Compare October 21, 2022 14:24
@jrmadsen jrmadsen merged commit a41a5c1 into ROCm:main Oct 21, 2022
@jrmadsen jrmadsen deleted the fix-sampling-ld-preload branch October 21, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Modifies the CMake build system libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library omnitrace-sample Involves the omnitrace-sample executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant