Skip to content

Fix deadlocks during initialization #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 26, 2022
Merged

Fix deadlocks during initialization #167

merged 6 commits into from
Sep 26, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Sep 22, 2022 •
edited
Loading

  • More to come in later commit, below is just tidying some stuff up
    • clang-tidy
    • mpi_gotcha quiet about not finding funcs
    • update to new papi config
    • sampling block_samples / unblock_samples
      • disable calling component's sample functions within sampler
    • release doesn't strip library
    • remove HSA and ROCP env variables from modulefile / setup-env
  • preliminary support for LD_PRELOAD usage
  • default sampling rate is 300 interrupts / second
  • fixes various deadlock issues at startup

@jrmadsen jrmadsen force-pushed the fix-openmp-target-deadlock branch from b9dea14 to 0a4935b Compare September 22, 2022 23:22
@jrmadsen
Miscellaneous cleanup
eb5b645 
- clang-tidy
- mpi_gotcha quiet about not finding funcs
- update to new papi config
- sampling block_samples / unblock_samples
  - disable calling component's sample functions within sampler
- release doesn't strip library
- remove HSA and ROCP env variables from modulefile / setup-env
@jrmadsen
Update API with omnitrace_init_tooling
5d3d8b4 
- Rocprofiler OnLoadToolProp and OnUnloadTool in omnitrace-dl
- Preliminary support for LD_PRELOAD usage
@jrmadsen
Update some config defaults
181abad 
- sampling freq is 300
- no mutex locking tracing by default
- mpip enabled by default
@jrmadsen jrmadsen force-pushed the fix-openmp-target-deadlock branch from 0a4935b to 181abad Compare September 23, 2022 01:23
@jrmadsen jrmadsen added bug fix Fixes a bug timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library sampling Statistical sampling via interrupts testing Extends/improves/modifies testing examples Adds new example or modifies existing example cmake Modifies the CMake build system submodule Updates a git submodule configuration Changes/involves configuration options labels Sep 26, 2022
@jrmadsen
process sampler and backtrace updates
4a348bf 
- process sampler promise on stack may get deleted so removed
- use cache in backtrace::get
@jrmadsen jrmadsen merged commit 8f36620 into ROCm:main Sep 26, 2022
@jrmadsen jrmadsen deleted the fix-openmp-target-deadlock branch September 26, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug cmake Modifies the CMake build system configuration Changes/involves configuration options examples Adds new example or modifies existing example libomnitrace Involves omnitrace library sampling Statistical sampling via interrupts submodule Updates a git submodule testing Extends/improves/modifies testing timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen