Skip to content

Fix reliability when KOKKOS_PROFILE_LIBRARY is set in env #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

jrmadsen
Copy link
Collaborator

  • in certain situations, an exe using kokkos may be instrumented
  • this will cause libomnitrace to be dlopened via libomnitrace-dl
  • if KOKKOS_PROFILE_LIBRARY is set to libomnitrace and not libomnitrace-dl, you will end up with different instances of libomnitrace trying to collect data
  • new OMNITRACE_ABORT macros
  • simplifies the definition of test environments
  • Adds new tests for KokkosP

@jrmadsen jrmadsen added bug fix Fixes a bug KokkosP Kokkos Performance Tools testing Extends/improves/modifies testing cmake Modifies the CMake build system labels Jul 21, 2022
@jrmadsen jrmadsen force-pushed the kokkos-profile-library-reliability branch 4 times, most recently from 4eee2b6 to 621e6a5 Compare July 23, 2022 08:03
jrmadsen added 2 commits July 24, 2022 20:34
- in certain situations, an exe using kokkos may be instrumented
- this will cause libomnitrace to be dlopened via libomnitrace-dl
- if KOKKOS_PROFILE_LIBRARY is set to libomnitrace and not libomnitrace-dl, you will end up with different instances of libomnitrace trying to collect data
@jrmadsen jrmadsen force-pushed the kokkos-profile-library-reliability branch from 621e6a5 to 3b72b56 Compare July 25, 2022 01:34
@jrmadsen jrmadsen merged commit bcdec18 into ROCm:main Jul 25, 2022
@jrmadsen jrmadsen deleted the kokkos-profile-library-reliability branch July 25, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug cmake Modifies the CMake build system KokkosP Kokkos Performance Tools testing Extends/improves/modifies testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant