Skip to content

[OMPIRBuilder] Pass kernel exec mode flags from outside #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

skatrak
Copy link
Member

@skatrak skatrak commented Dec 3, 2024

This patch allows OMPIRBuilder users to specify the kernel execution mode directly, so that it can distinguish between Generic, Generic-SPMD and SPMD rather than taking a choice between two of the options based on an incomplete boolean IsSPMD flag.

This patch allows OMPIRBuilder users to specify the kernel execution mode
directly, so that it can distinguish between Generic, Generic-SPMD and SPMD
rather than taking a choice between two of the options based on an incomplete
boolean `IsSPMD` flag.
Copy link

@DominikAdamski DominikAdamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatrak skatrak merged commit 44dac2e into ROCm:amd-trunk-dev Dec 3, 2024
3 of 5 checks passed
@skatrak skatrak deleted the kernel-flags branch December 3, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants