-
Notifications
You must be signed in to change notification settings - Fork 142
update changlog #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jichangjichang
wants to merge
1
commit into
ROCm:release-staging/rocm-rel-7.0
Choose a base branch
from
jichangjichang:changelog_7.0
base: release-staging/rocm-rel-7.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update changlog #2222
jichangjichang
wants to merge
1
commit into
ROCm:release-staging/rocm-rel-7.0
from
jichangjichang:changelog_7.0
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-jnovotny
previously approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor rewording suggestion, but otherwise looks good.
CHANGELOG.md
Outdated
@@ -4,9 +4,12 @@ Full documentation for hipBLASLt is available at [rocm.docs.amd.com/projects/hip | |||
|
|||
## hipBLASLt 1.0.0 for ROCm 7.0.0 | |||
|
|||
### Added | |||
|
|||
* Added``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for setting scalar (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``) or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* Added``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for setting scalar (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``) or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``). | |
* Added the ``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for configuring (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``), or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``) settings. |
ff81807
to
d7e2daf
Compare
amd-jnovotny
approved these changes
Jun 12, 2025
this PR has merge conflicts and cannot be cleanly imported, please resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.