Skip to content

Deprecate AMDGPU_TARGETS variable #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: release-staging/rocm-rel-6.5
Choose a base branch
from
Open

Deprecate AMDGPU_TARGETS variable #1770

wants to merge 5 commits into from
+10 −4

Conversation

lawruble13
Copy link
Contributor

Summary of proposed changes:

  • Change the CMake to set the GPU_TARGETS variable from AMDGPU_TARGETS if not set by the user
  • Change usages of AMDGPU_TARGETS to GPU_TARGETS

Note that #1563 was opened against 6.4, which I did not merge in time for 6.4, hence why this PR is being opened.

@lawruble13 lawruble13 marked this pull request as ready for review March 13, 2025 20:08
@jayhawk-commits
Copy link
Contributor

Not migrating this PR to the monorepo due to the target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawruble13 @jayhawk-commits