Skip to content

Add description for ActivationType in Common.py #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

StaceyLai
Copy link
Contributor

Add a description for ActivationType in common.py to help users be aware of the need to set this field.
ActivationType now supports "all", "hipblaslt_all" and "none". There are two reasons why it's not suitable to directly assign a default value to ActivationType now: 1. It's unclear whether the source is from Tensile or hipBLASLT; 2. It may cause a mismatch between the solution's config and the problemType.

@StaceyLai
Copy link
Contributor Author

local CI pass:

[----------] 1 test from ExtOpTest/ExtOpAMaxWithScaleUnsupportedDatatypeTest
[ RUN ] ExtOpTest/ExtOpAMaxWithScaleUnsupportedDatatypeTest.amaxWithScaleFailureUnsupportedDatatype/0
[ OK ] ExtOpTest/ExtOpAMaxWithScaleUnsupportedDatatypeTest.amaxWithScaleFailureUnsupportedDatatype/0 (0 ms)
[----------] 1 test from ExtOpTest/ExtOpAMaxWithScaleUnsupportedDatatypeTest (0 ms total)

[----------] Global test environment tear-down
[==========] 48206 tests from 13 test suites ran. (1278982 ms total)
[ PASSED ] 48206 tests.
hipBLASLt version: 1000

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
---------- generated xml file: /stacelai/tensilelite/python_tests.xml ----------
========= 76 passed, 32 skipped, 1253 warnings in 11693.87s (3:14:53) ==========
py3: exit 0 (11694.12 seconds) /stacelai/tensilelite> py.test -v --basetemp=/stacelai/tensilelite/CI_out/py3/tmp --junit-xml=/stacelai/tensilelite/python_tests.xml --junit-prefix=py3 --color=yes -n 4 --prebuilt-client=/stacelai/tensilelite/CI_out/py3/client/0_Build/client/tensile_client Tensile/Tests -m common pid=2697306
py3: OK (11837.06=setup[11.06]+cmd[0.63,131.25,11694.12] seconds)
congratulations :) (11837.13 seconds)

@@ -1353,6 +1353,10 @@ def supportedCompiler(compiler: str) -> bool:
# Activation
"Activation": False,
"ActivationNoGuard": False,
# ActivationType supports "none", "all" (10 activations) and "hipblaslt_all" (dgelu, gelu and relu).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActivationType also support single activation except "none", "all" and "relu".

@eidenyoshida eidenyoshida added the noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. label May 15, 2025
@jayhawk-commits
Copy link
Contributor

Please resolve merge conflicts or close this PR to complete the task of importing PRs from this repo to the monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noCI Disable testing on supported CI systems: math libraries CI has this feature enabled..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants