[Build] Optimize makefile to auto remove outdated binary tools #214
+26
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yansun1996
force-pushed
the
auto_update_binary
branch
from
d168114 to
1f31d17
Compare
sajmera-pensando
force-pushed
the
staging
branch
2 times, most recently
from
739cc70 to
ca93ffe
Compare
yansun1996
force-pushed
the
auto_update_binary
branch
from
1f31d17 to
63ea84d
Compare
shiv-tyagi
reviewed
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Currently when we changed the binary tools version, the old binaries won't get auto updated. For example we have updated the
controller-genversion over different branches, when we switch among branches to do the build, the outdatedcontroller-gencould result in massive auto-generated files differences.Improvement:
In the Makefile, if the binary tool is existing, check the version. If the version mismatch with the desired version, re-download the binary tool so that the correct version tool could be used for building the project.