Skip to content

Added fp8 gemm gelu_aux_bias support in release 1.9 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release_v1.9_rocm
Choose a base branch
from

Conversation

VeeraRajasekhar
Copy link
Contributor

Description

Added support to fp8 gelu_aux_bias in releaseV1.9

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Added a new test case fp8Xfp8Xfp16Xfp16Xfp8

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wenchenvincent
Copy link
Collaborator

@VeeraRajasekhar There seems to be a build issue.

@VeeraRajasekhar VeeraRajasekhar force-pushed the release_v1.9_rocm_fp8_gemm branch from 091ab04 to 2b5fa5c Compare May 1, 2025 15:49
Copy link
Contributor

@wangye805 wangye805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeeraRajasekhar VeeraRajasekhar force-pushed the release_v1.9_rocm_fp8_gemm branch from ce412ff to aee8e04 Compare May 2, 2025 21:31
@VeeraRajasekhar VeeraRajasekhar requested a review from ipanfilo May 8, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants