Disable ZeroOutBuffer for CK Grouped Conv Fwd #3756
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekxk
requested review from
BrianHarrisonAMD,
BradPepersAMD,
adickin-amd and
JonathanLichtnerAMD
as code owners
|
I think we will want to hold off on merging this until we have all the clears only happening under the correct conditions, and we can do extensive testing to ensure we don't encounter additional NaN or accuracy issues. I believe the plan is to remove all the extra clears from MIOpen, and allow CK to clear when needed instead. |
|
I think this can be closed and is covered by #3783 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.