Skip to content

Handle vscode-notebook-cell in path_from_uri #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Apr 20, 2023

This PR makes path_from_uri handle uri like vscode-notebook-cell:// so that the lintr diagnostics could work properly with R code cells in juypter notebooks in vscode as reported at REditorSupport/vscode-R#1198.

Copy link
Member

@randy3k randy3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 4752951 into REditorSupport:master Apr 20, 2023
@osmano807
Copy link

I'm still affected by this issue using rev 1e71561 with a Windows VSCode and Linux Jupyter Lab server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants