-
Notifications
You must be signed in to change notification settings - Fork 99
Make headers in help hover look prettier #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make headers in help hover look prettier #392
Conversation
That looks quite nice as well. What bothers me a bit here (and in the original version) is the vertical space taken up by the large heading plus the line "Encoding {base}", which I tried to reduce by moving the package info into the heading. What do you think about these? replacement <- "<b>\\1</b> <i>{\\2}</i><br/>\\3<hr/>"
pattern <- "<table.*?<td>(.*?)\\s*{(.*?)}<\\/td>.*?<\\/table>\\n*<h2>\\s*(.*?)\\s*<\\/h2>" |
It looks good! Let's use this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pandoc >= 2.0
pandoc < 2.0
Looks llike |
Fixed via 62b06e5. replacement <- "<b>\\1</b> <i>{\\2}</i><p>\\3</p><hr/>" |
Modifies the header of help hovers to remove the first line.
Information about the package is moved to the first proper header instead.